Hue crate changes needed for implementing wake-up automation #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duvholt
commented
May 8, 2025
chrivers
reviewed
May 9, 2025
chrivers
reviewed
May 9, 2025
Owner
|
Thanks for coming back for round 3! :) This is looking great! Absolutely minor stuff, easily fixed. Then we can get this half merged, and that will make everything easier 👍 |
Since this type is both highly dynamic and unknown we'll instead deserialize it after retrieving it from the state
This is still just a guess but it makes sense with the minimal sampling we have
We'll do any error handling when creating the update instead
duvholt
force-pushed
the
wake-up-sunrise-hue-crate
branch
from
1acaae0 to
a97fd39
Compare
Contributor
Author
|
Should be ready for another review now |
Owner
|
Looking great new! Thanks for doing another round on this. And now... let's merge! 🥳 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased version of #113 with only the
huecrate changes. Hopefully this makes it easier to merge 😄