Skip to content

simplify flow respose sending#248

Open
christophsturm wants to merge 1 commit intomainfrom
simplify-coroutines-handler
Open

simplify flow respose sending#248
christophsturm wants to merge 1 commit intomainfrom
simplify-coroutines-handler

Conversation

@christophsturm
Copy link
Copy Markdown
Owner

i looked at the code again after a long time and it seemed a bit too complicated

@github-actions
Copy link
Copy Markdown

Advice for :restaurant-core
Unused dependencies which should be removed:
  implementation("org.jetbrains.kotlinx:kotlinx-coroutines-jdk8:1.10.1")
  testImplementation(project(":restaurant-test-common"))

These transitive dependencies should be declared directly:
  testImplementation("dev.failgood:failgood:0.9.1")
  testImplementation("org.jetbrains.kotlin:kotlin-test:2.1.10")

Advice for :restaurant-jackson
Unused dependencies which should be removed:
  testImplementation(project(":restaurant-test-common"))

These transitive dependencies should be declared directly:
  api(project(":restaurant-core"))
  implementation(project(":restaurant-client"))
  testImplementation("dev.failgood:failgood:0.9.1")
  testImplementation("org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.1")
  testImplementation(project(":restaurant-client"))
  testImplementation(project(":restaurant-core"))

Existing dependencies which should be modified to be as indicated:
  testImplementation(project(":restaurant-rest")) (was api)

Advice for :restaurant-jwt
Unused dependencies which should be removed:
  testImplementation(project(":restaurant-test-common"))

These transitive dependencies should be declared directly:
  testImplementation("dev.failgood:failgood:0.9.1")
  testImplementation(project(":restaurant-client"))

Advice for :restaurant-kotlinx-serialization
Unused dependencies which should be removed:
  testImplementation(project(":restaurant-test-common"))

These transitive dependencies should be declared directly:
  api("org.jetbrains.kotlinx:kotlinx-serialization-core:1.8.0")
  api(project(":restaurant-core"))
  implementation("org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.1")
  implementation(project(":restaurant-client"))
  testImplementation("org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.1")
  testImplementation("org.jetbrains.kotlinx:kotlinx-serialization-core:1.8.0")
  testImplementation(project(":restaurant-client"))
  testImplementation(project(":restaurant-core"))

Existing dependencies which should be modified to be as indicated:
  testImplementation(project(":restaurant-rest")) (was api)

Advice for :restaurant-rest
These transitive dependencies should be declared directly:
  implementation("org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.1")
  implementation(project(":restaurant-client"))
  testImplementation("org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.1")

Advice for :restaurant-server-test
These transitive dependencies should be declared directly:
  testImplementation(project(":restaurant-client"))

Existing dependencies which should be modified to be as indicated:
  testImplementation(project(":restaurant-core")) (was api)

Advice for :restaurant-test-common
Unused dependencies which should be removed:
  api("org.jetbrains.kotlin:kotlin-test:2.1.10")
  testImplementation("org.jetbrains.kotlin:kotlin-test:2.1.10") { capabilities {
    requireCapability("org.jetbrains.kotlin:kotlin-test-framework-junit5")
  }}

Dependencies which should be removed or changed to runtime-only:
  runtimeOnly("ch.qos.logback:logback-classic:1.5.16") (was implementation)
  runtimeOnly("dev.failgood:failgood:0.9.1") (was api)
  runtimeOnly("org.jetbrains.kotlin:kotlin-test-junit5:2.1.10") (was api)


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant