Some minor fixes and updates #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compilation flags inherited from the Geant4 build possibly force compiler flag `-std=c++11`. If so, compilation under `gcc` fails because the C++11 standard doesn't support curly brace aggregate initialization with classes having member-initializers (e.g., `CADMesh::File::Token`). This restriction was later lifted. Forcing compilation to the C++14 or later standard fixes this problem, resolving upstream Issues 21 and 24.
Currently, only `CADMesh.hh` is installed. Update `CMakeLists.txt` so that every header from the source `include` directory is installed.
bnara
changed the title
CMake creates the configuration file `cadmesh-config.cmake` from `cadmesh-config.cmake.in`. Update the CMake module path so that the example builds have access to the configured file.
When `WITH_SYS_ASSIMP=OFF`, CMake builds assimp from GitHub. Allow the user to specify a GitHub release tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for making this code available. It is of great help in our work. I have a few minor fixes and updates.