Add React 19 support by migrating from defaultProps to default parame…#119
Open
keisuke-na wants to merge 2 commits intochrisrzhou:mainfrom
Open
Add React 19 support by migrating from defaultProps to default parame…#119keisuke-na wants to merge 2 commits intochrisrzhou:mainfrom
keisuke-na wants to merge 2 commits intochrisrzhou:mainfrom
Conversation
…ters This commit adds React 19 compatibility by replacing the deprecated defaultProps pattern with ES6 default parameters and useMemo hooks. Changes: - Remove ReactWordCloud.defaultProps (deprecated in React 19) - Add DEFAULT_MIN_SIZE constant to prevent reference issues - Use useMemo for minSize and svgAttributes to maintain stable references - Move mergedCallbacks and mergedOptions into useEffect - Update useEffect dependencies (exclude 'size' to prevent infinite loops) - Add explanatory comment for eslint-disable-next-line Technical details: - React 19 ignores defaultProps on function components - Default parameter arrays create new references on each render - Module-level constants ensure stable references for useMemo - 'size' excluded from dependencies as it's managed by useResponsiveSvgSelection and including it could cause infinite re-render loops Tested with React 19.1.1
- Upgrade TypeScript from 3.8.3 to 5.0.0 - Add @types/react and @types/react-dom for better type safety - Update tsconfig.json with skipLibCheck and strict: false - Fix type errors in hooks.js with proper null checks - Add @ts-ignore comments for TypeScript type inference issues This resolves the build errors that were occurring with outdated TypeScript version and newer type definition packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds React 19 compatibility by replacing the deprecated
defaultPropspattern with ES6 default parameters anduseMemohooks.
Changes
ReactWordCloud.defaultProps(deprecated in React 19)DEFAULT_MIN_SIZEconstant to prevent reference issuesuseMemoforminSizeandsvgAttributesto maintain stable referencesmergedCallbacksandmergedOptionsintouseEffectuseEffectdependencies (excludesizeto prevent infinite loops)eslint-disable-next-lineTechnical Details
defaultPropson function componentsuseMemosizeexcluded from dependencies as it's managed byuseResponsiveSvgSelectionand including it could cause infinitere-render loops
Testing
Tested with React 19.1.1 and verified basic wordcloud rendering works without infinite loops.
Note
The pre-push hook fails due to TypeScript errors in
node_modules/@types/*files. This appears to be an existing issue with theTypeScript version (3.8.3) and newer type definitions.