Open
Conversation
chrisostome01
force-pushed
the
be-commenting
branch
from
44e7252 to
0185324
Compare
chrisostome01
force-pushed
the
be-commenting
branch
from
0185324 to
e38f4ac
Compare
renepromesse
requested changes
Dec 29, 2021
Collaborator
renepromesse
left a comment
renepromesse
left a comment
There was a problem hiding this comment.
Hey @sezeranoJchrisostome, you did good work.
please follow the feedback given and let me know afterward.
js/blog.js
Outdated
| @@ -1,7 +1,288 @@ | |||
| /* Database configuration */ | |||
Collaborator
There was a problem hiding this comment.
this file is too long, break it down according to the features it holds
- have maybe other 2 files, just to have small clean manageable files
Collaborator
|
@sezeranoJchrisostome Looking at your project structure please, move the images folder inside the assets folder |
Collaborator
|
on this sections or anywhere in your pages, it is much better to keep your text left-aligned, not centered |
Collaborator
|
please fix these images to be full-circled |
Collaborator
|
add a way to close the comments popup |
Collaborator
|
on the blog page, the skills, projects and contact menus are not working |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this pr does
How you may test it
Related trello board
Commenting board