Add Redis connection helpers to _redis.py #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidates Redis connection management into `_redis.py` as preparation for cluster support: - Add `is_cluster_url()` to detect `redis+cluster://` URLs - Add `redis_connection()` context manager for getting Redis clients - Add `pubsub_connection()` context manager for pub/sub connections - Update `Docket.redis()` to use `redis_connection()` - Add `Docket._pubsub()` method for direct pub/sub access - Update worker and execution modules to use `_pubsub()` All cluster URL paths raise `NotImplementedError` for now - actual cluster support will come in a future PR. Also adds `raise NotImplementedError` to coverage exclusions since these are intentionally unreachable until cluster is implemented. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
📚 Documentation has been built for this PR! You can download the documentation directly here: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #271 +/- ##
===========================================
- Coverage 100.00% 99.96% -0.04%
===========================================
Files 55 55
Lines 9074 9080 +6
Branches 450 453 +3
===========================================
+ Hits 9074 9077 +3
- Misses 0 3 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Use simple `async with` instead of manual __aenter__/__aexit__ with shield - the shield wasn't doing anything since we pass a connection pool and auto_close_connection_pool is False. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidates Redis connection management into
_redis.pyas preparation for cluster support:is_cluster_url()to detectredis+cluster://URLsredis_connection()context manager for getting Redis clientspubsub_connection()context manager for pub/sub connectionsDocket.redis()to useredis_connection()Docket._pubsub()method for direct pub/sub access_pubsub()All cluster URL paths raise
NotImplementedErrorfor now - actual cluster support will come in a future PR.Also adds
raise NotImplementedErrorto coverage exclusions since these are intentionally unreachable until cluster is implemented.🤖 Generated with Claude Code