feat(Algebra/LocalIso): prove of_bijective and comp for RingHom.IsLocalIso#24
Open
chrisflav wants to merge 4 commits intochrisflav:masterfrom
Open
feat(Algebra/LocalIso): prove of_bijective and comp for RingHom.IsLocalIso#24chrisflav wants to merge 4 commits intochrisflav:masterfrom
chrisflav wants to merge 4 commits intochrisflav:masterfrom
Conversation
…alIso Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
chrisflav
commented
Mar 17, 2026
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
chrisflav
commented
Mar 17, 2026
- Add `@[algebraize]` tag to `RingHom.IsLocalIso` so the algebraize tactic can automatically generate `Algebra.IsLocalIso` instances from `RingHom.IsLocalIso` hypotheses - Import `Mathlib.Tactic.Algebraize` - Use `algebraize [f, g, g.comp f]` in `comp` instead of manual instance setup - Use `inferInstance` in `of_bijective` instead of the auto-generated instance name Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ings Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prove
RingHom.IsLocalIso.of_bijective: a bijective ring homomorphism is a local isomorphism.Prove
RingHom.IsLocalIso.comp: the composition of two local isomorphisms is a local isomorphism. The proof localizes at primes of the target, lifts elements viaIsLocalization.Away.surj, and builds the requiredIsStandardOpenImmersioninstances by composing localization equivalences.