feat(Topology/SpectralSpace/WLocal/Basic): fill some sorries#21
Merged
chrisflav merged 9 commits intochrisflav:masterfrom Mar 17, 2026
Merged
Conversation
…lemmas Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
chrisflav
commented
Mar 12, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
chrisflav
commented
Mar 12, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
chrisflav
commented
Mar 14, 2026
- Remove trivial `closedPoints_eq_preimage` lemma - Remove spurious `[WLocalSpace Y]` from `IsEmbedding.isClosed_singleton_image` and `IsEmbedding.closedPoints_eq_preimage` - Simplify `IsClosedEmbedding.wLocalSpace` using `wLocalSpace_of_stableUnderSpecialization_range` and `IsClosed.stableUnderSpecialization` Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Split semicolon-chained tactics onto separate lines - Rename `isClosed_singleton` → `isClosed_image_singleton` in `IsClosedMap` and `IsWLocalMap` namespaces to clarify the name describes the image of a singleton - Rename `IsEmbedding.isClosed_singleton_image` → `IsEmbedding.isClosed_image_singleton` for consistency with Mathlib naming convention - Rename `IsEmbedding.isClosed_singleton_of_isClosed_image` → `IsEmbedding.isClosed_singleton_of_isClosed_image_singleton` to make clear the hypothesis concerns an image singleton Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
chrisflav
commented
Mar 16, 2026
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Revert unrelated change at line 97 (`by simp [isClopen_univ]` → `isClopen_univ, Set.mem_univ x`) - Fix `rw [(t2Space_iff _)]` → `rw [t2Space_iff]` - Extract `hsat` block as `IsClopen.connectedComponents_image_isClopen` in `TotallyDisconnected.lean` (earlier in hierarchy) - Restore proofs for `t2Space_connectedComponent` and `lift_bijective_of_isPullback` Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This reverts commit 437b957.
chrisflav
commented
Mar 17, 2026
…ic file about IsClosedMap Move `IsClosedMap.isClosed_singleton` from `Proetale/Mathlib/Topology/Separation/Basic.lean` to the more appropriate `Proetale/Mathlib/Topology/Maps/Basic.lean`, following the Mathlib file structure where `IsClosedMap` is defined in `Mathlib.Topology.Maps.Basic`. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.