Open
Conversation
feat: complete `Proetale.Topology.SpectralSpace.WLocal.Basic` and refactor some files
chrisflav
reviewed
Feb 1, 2026
Owner
chrisflav
left a comment
chrisflav
left a comment
There was a problem hiding this comment.
This is quite impressive, thanks! Could you please clarify how much of this was done by codex? And how much post-processing did you do?
| @[stacks 096E "(1)"] | ||
| def RingHom.IsLocalIso {R S : Type*} [CommSemiring R] [CommSemiring S] (f : R →+* S) : Prop := | ||
| letI := f.toAlgebra | ||
| let := f.toAlgebra |
Owner
There was a problem hiding this comment.
This should remain letI. Did codex change that on its own?
Collaborator
There was a problem hiding this comment.
Yes, codex often has their own mind.
Collaborator
There was a problem hiding this comment.
I think this is because we asked codex to golf the proof it generated. As a result, it also golfed other proofs as well.
Collaborator
|
Almost every line of the code is generated by codex. We also asked codex to golf its own proof. Codex also fixed some small errors (e.g. used union where it should be intersection) in the statements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PKU lean workshop, we tried AI tool--codex to automatically fill some sorry, which was quite amazing.