feat(members/excursion): various fixes and LJP proposal enhancements#230
Open
mariusrklein wants to merge 6 commits intomainfrom
Open
feat(members/excursion): various fixes and LJP proposal enhancements#230mariusrklein wants to merge 6 commits intomainfrom
mariusrklein wants to merge 6 commits intomainfrom
Conversation
…ar ones this includes to the following features: - calculation of org fee should be disabled for older participants in a yl activity - calculation of ljp participants is different for yl acitivitis: there is no age limit. - as a consequence, paid and requested ljp contributions are considerably higher the ljp goal qualification can only occur with the category staff training (also the negation of both). This is restricted by a field validation so the discrimination can check for just one of the fields.
the document - lists all bills for an activity - adds up all allowances on top of the bill overview - adds a custom receipt for the allowances - appends all other receipts in their order on the list
|
📚 Documentation deployed! Documentation: https://chrisflav.github.io/kompass/mk-excursion-fixes/ Docker Images:
Add the |
chrisflav
reviewed
Mar 8, 2026
Owner
chrisflav
left a comment
chrisflav
left a comment
There was a problem hiding this comment.
Do I understand correctly that now the finance report is required, but not the actual scanned invoices? Otherwise I am confused why we don't add the invoices to the current LJP finance overview.
Comment on lines
+414
to
+415
| "Das Lernziel 'Qualifizierung' kann nur in Kombination mit der Kategorie " | ||
| "'Jugendleiter*innenweiterbildung' verwendet werden." |
Owner
There was a problem hiding this comment.
Suggested change
| "Das Lernziel 'Qualifizierung' kann nur in Kombination mit der Kategorie " | |
| "'Jugendleiter*innenweiterbildung' verwendet werden." | |
| "Das Bildungsziel 'Qualifizierung' kann nur in Kombination mit der Kategorie " | |
| "'Jugendleiter*innenweiterbildung' verwendet werden." |
Comment on lines
+629
to
+630
| msgid "only relevant for a LJP application" | ||
| msgstr "nur für einen LJP-Antrag relevant" |
Owner
There was a problem hiding this comment.
Suggested change
| msgid "only relevant for a LJP application" | |
| msgstr "nur für einen LJP-Antrag relevant" | |
| msgid "Only relevant for a LJP application." | |
| msgstr "Nur für einen LJP-Antrag relevant." |
chrisflav
changed the title
chrisflav
changed the title
Co-authored-by: Christian Merten <christian@merten.dev>
Co-authored-by: Christian Merten <christian@merten.dev>
Co-authored-by: Christian Merten <christian@merten.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• Full receipt overview for LJP proposals – Added new LaTeX template (ljp_statement.tex) to generate comprehensive invoice and receipt summaries with all supporting documentation
• Download LJP proofs functionality – Implemented download_ljp_proofs() method in admin panel to generate and download complete proof collections with attachments (right next to other lip documents)
• Improved LJP participant counting – Fixed distinction between regular participants and LJP-eligible participants; introduced ljp_participant_count property for accurate subsidies calculation in excursion cost overview
• Qualification activity handling – Activities with qualification goal no longer apply age restrictions to participants and correctly exempt org fees
• Enhanced LJP proposal validation – Added custom form validation to enforce category-goal combinations: Qualification requires Staff Training category; other goals require Educational Programme
• Updated help texts & translations – Added clarifying help texts for night costs, kilometers traveled, and postcode fields; improved German translations throughout
• Org fee logic refinement – Org fees only charged when subsidies or allowances claimed, excluding qualification activities entirely
• UI improvements – Reordered fields in Freizeit admin for better logical flow; updated German translations for LJP-related terminology