Fix malformed payload when bundeling multiple commits#36
Open
tabakhase wants to merge 1 commit intochriseldredge:masterfrom
Open
Fix malformed payload when bundeling multiple commits#36tabakhase wants to merge 1 commit intochriseldredge:masterfrom
tabakhase wants to merge 1 commit intochriseldredge:masterfrom
Conversation
|
that patch doesn't fix the issue either. negating [^;]* does prevent the .* from being greedy, but then any ';' in the preceding field will cause the group to be shorter than it should. |
Author
|
Im also not super happy with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reference to #24 as #27 is not fixing it (using gitweb)
resolves the greedy regex to produce
","short":false}]},&&&&&Tabakhase","value":(using negative look-around would be cleaner, but does not seem to work there)