Skip to content

Fix infinite ticks when using negative multiplier#37

Open
stephg wants to merge 2 commits intochrisbateman:masterfrom
factisresearch:fix-neg-multiplier
Open

Fix infinite ticks when using negative multiplier#37
stephg wants to merge 2 commits intochrisbateman:masterfrom
factisresearch:fix-neg-multiplier

Conversation

@stephg
Copy link
Copy Markdown

@stephg stephg commented Jan 18, 2018

I was using impetus to update scrollLeft and scrollTop of a parent container and thus using a negative multiplier to invert scroll direction.

Then the stop condition for requesting new animation frames was never hit.
destroy() can't stop it either - that would be worth a fix too (#31).

@GianlucaGuarini
Copy link
Copy Markdown

This patch solves a really important issue. @chrisbateman have you any plan to merge it anytime soon? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants