Fix infinite ticks when using negative multiplier#37
Open
stephg wants to merge 2 commits intochrisbateman:masterfrom
Open
Fix infinite ticks when using negative multiplier#37stephg wants to merge 2 commits intochrisbateman:masterfrom
stephg wants to merge 2 commits intochrisbateman:masterfrom
Conversation
|
This patch solves a really important issue. @chrisbateman have you any plan to merge it anytime soon? Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was using impetus to update
scrollLeftandscrollTopof a parent container and thus using a negative multiplier to invert scroll direction.Then the stop condition for requesting new animation frames was never hit.
destroy()can't stop it either - that would be worth a fix too (#31).