Open
Conversation
Owner
Author
|
@claude fill out the PR description |
|
Claude finished @chowbao's task in 1m 11s —— View job PR DescriptionHere is the filled-out PR description based on the changes in this PR: WhatRemoves unused code across multiple packages, including deleted files and unused functions/types:
WhyThese code paths were no longer referenced anywhere in the codebase and were dead code. Removing them reduces maintenance burden, eliminates confusion about supported export types, and keeps the codebase aligned with the features that are actively used and maintained. Known limitationsN/A
|
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
Thoroughness
Release planning
What
Removes unused code that is no longer referenced anywhere in the codebase:
cmd/export_ledger_transaction.go— theexport_ledger_transactionCLI command and its testsinternal/input/all_history.go— theall_historyinput moduleinternal/input/orderbooks.go— theorderbooksinput moduleinternal/transform/ledger_transaction.go— theledger_transactiontransform and its testsinternal/transform/offer_normalized.go— theoffer_normalizedtransform and its teststestdata/ledger_transactions/ledger_transactions.golden— associated test golden fileinternal/toid,internal/transform/schema.go, andinternal/utils/main.goWhy
These modules were dead code — not referenced by any active command or pipeline. Removing them reduces maintenance burden, keeps the codebase easier to navigate, and avoids confusion about whether these exports are still supported.
Known limitations
N/A