feat: separate diagnostic and system events into history_diagnostic_events table#17
Open
feat: separate diagnostic and system events into history_diagnostic_events table#17
Conversation
…c_events command
- Add eventTypes []xdr.ContractEventType filter parameter to TransformContractEvent
- history_contract_events (export_contract_events) now only emits ContractEventTypeContract events
- New export_diagnostic_events command emits ContractEventTypeDiagnostic and ContractEventTypeSystem events
- Both commands share the same ContractEventOutput schema and transform logic
- Add empty golden file placeholder for diagnostic_events integration test
Note: integration test golden files need regeneration:
- testdata/contract_events/ golden file needs diagnostic events removed
- testdata/diagnostic_events/ golden file needs to be generated
Run with: go test -v -run ^TestExportContractEvents$ ./cmd -args -update=true
go test -v -run ^TestExportDiagnosticEvents$ ./cmd -args -update=true
Closes #16
Co-authored-by: chowbao <chowbao@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16
Summary
To improve performance of
history_contract_events, this PR separates diagnostic and system events into a newhistory_diagnostic_eventstable.Changes
eventTypes []xdr.ContractEventTypefilter parameter toTransformContractEventexport_contract_eventsnow only emitsContractEventTypeContracteventsexport_diagnostic_eventscommand emitsContractEventTypeDiagnostic+ContractEventTypeSystemeventsContractEventOutputschema and parquet writerNote
Integration test golden files need regeneration after merging (requires Docker + GCP credentials).
Generated with Claude Code