Skip to content

refactor: @Transactional(readOnly=true) 중첩사용 #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boyekim wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: @Transactional(readOnly=true) 중첩사용 #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ecd60e
style: 라인정리
boyekim Oct 21, 2024
02627ce
refactor: @Transactional readonly 중첩사용
boyekim Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/cholog/supp/api/comment/dto/request/ModifyCommentRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

public record ModifyCommentRequest(
Long commentId,
String content) {
String content
) {

}
5 changes: 4 additions & 1 deletion src/main/java/cholog/supp/api/member/dto/request/SignInMember.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
package cholog.supp.api.member.dto.request;

public record SignInMember(String email, String password) {
public record SignInMember(
String email,
String password
) {

}
5 changes: 4 additions & 1 deletion src/main/java/cholog/supp/api/member/dto/request/SignUpMember.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
package cholog.supp.api.member.dto.request;

public record SignUpMember(String email, String password) {
public record SignUpMember(
String email,
String password
) {

}
3 changes: 2 additions & 1 deletion src/main/java/cholog/supp/api/post/dto/ModifyPost.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

public record ModifyPost(
String title,
String description) {
String description
) {

}
3 changes: 2 additions & 1 deletion src/main/java/cholog/supp/api/post/dto/request/CreatePostRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
public record CreatePostRequest(
String title,
String description,
Long studyId) {
Long studyId
) {

}
7 changes: 0 additions & 7 deletions src/main/java/cholog/supp/api/post/dto/request/PostsRequest.java
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions src/main/java/cholog/supp/api/post/service/PostService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ public EachPostResponse getEachPost(Member member, Long postId) {
return new EachPostResponse(eachPost, comments);
}

@Transactional(readOnly = true)
public List<EachComment> getCommentList(Long studyId, List<Comment> comments, Member member) {
return comments.stream().map(comment -> {
Member nowCommentMember = comment.getMember();
Copy link
Copy Markdown
Member

@gogo1414 gogo1414 Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Member nowCommentMember = comment.getMember();
Member �commentMember = comment.getMember();

변수 네이밍을 이렇게 바꾸는건 어때?? nowCommentMember도 직관적인 표현이긴 한데, now가 없어도 이해가 되는 의미라고 생각해서!
편한대로 적용하면 좋을거 같어!

Copy link
Copy Markdown
Member

@gogo1414 gogo1414 Oct 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스크린샷 2024-10-22 오후 5 36 54 스크린샷 2024-10-22 오후 5 37 24

두 이미지를 보면 변수 네이밍에 대해 깃헙 코드로 해본건데 nowCommentMember 변수 네이밍이 우리 코드밖에 없네😂

Expand All @@ -90,6 +89,4 @@ public List<EachComment> getCommentList(Long studyId, List<Comment> comments, Me
return new EachComment(comment, memberType, isAuthor);
}).toList();
}


}
3 changes: 2 additions & 1 deletion src/main/java/cholog/supp/api/studygroup/dto/request/CreateStudyGroupRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

public record CreateStudyGroupRequest(
String studyName,
String organization) {
String organization
) {

}