This repository was archived by the owner on Oct 11, 2021. It is now read-only.
(GH-107) Valid PowerShell Requirement#129
Open
gep13 wants to merge 1 commit intochocolatey-archive:masterfrom
Open
(GH-107) Valid PowerShell Requirement#129gep13 wants to merge 1 commit intochocolatey-archive:masterfrom
gep13 wants to merge 1 commit intochocolatey-archive:masterfrom
Conversation
Member
Author
|
@ferventcoder the Tokenize method isn't working how I would expect it to, or I haven't written the test correctly. I "think" I have given it some invalid PowerShell, but the error count is still zero. Am I mis-understanding how this should work? |
| <Reference Include="System.ComponentModel.DataAnnotations" /> | ||
| <Reference Include="System.Configuration" /> | ||
| <Reference Include="System.Core" /> | ||
| <Reference Include="System.Management.Automation, Version=3.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL"> |
Contributor
There was a problem hiding this comment.
Look exactly at how Choco puts in this reference. You may want to emulate that.
Contributor
|
With the tokenize method, I'm not sure. It should give you a valid error count. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #107