Skip to content

Fix issue #26: run-qa-agent.sh and run-report-agent.sh don't build binary if missing #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpleva91 merged 1 commit into from
Apr 4, 2026
Merged

Fix issue #26: run-qa-agent.sh and run-report-agent.sh don't build binary if missing #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions scripts/run-qa-agent.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
#!/usr/bin/env bash
set -euo pipefail
cd "$(dirname "$0")/.."

if [[ ! -f ./shellforge ]]; then
Copy link

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existence check uses [[ ! -f ./shellforge ]], but the script later executes ./shellforge. If the file exists but isn’t executable (e.g., permissions changed), this will skip the build and then fail at exec. Consider checking -x (or ensuring executable via chmod +x) so the script reliably produces a runnable binary when needed.

Suggested change
if [[ ! -f ./shellforge ]]; then
if [[ ! -x ./shellforge ]]; then

Copilot uses AI. Check for mistakes.
echo "[run-qa-agent] Building shellforge..."
go build -o shellforge ./cmd/shellforge
fi

exec ./shellforge qa "${1:-.}"
Comment on lines +5 to 10
Copy link

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This build-and-run logic duplicates scripts/run-agent.sh (which already builds ./shellforge when missing). Consider delegating to run-agent.sh qa ... to avoid the runners drifting (e.g., differing build flags or checks) as future changes happen.

Suggested change
if [[ ! -f ./shellforge ]]; then
echo "[run-qa-agent] Building shellforge..."
go build -o shellforge ./cmd/shellforge
fi
exec ./shellforge qa "${1:-.}"
exec ./scripts/run-agent.sh qa "${1:-.}"

Copilot uses AI. Check for mistakes.
6 changes: 6 additions & 0 deletions scripts/run-report-agent.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
#!/usr/bin/env bash
set -euo pipefail
cd "$(dirname "$0")/.."

if [[ ! -f ./shellforge ]]; then
Copy link

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existence check uses [[ ! -f ./shellforge ]], but the script later executes ./shellforge. If the file exists but isn’t executable (e.g., permissions changed), this will skip the build and then fail at exec. Consider checking -x (or ensuring executable via chmod +x) so the script reliably produces a runnable binary when needed.

Suggested change
if [[ ! -f ./shellforge ]]; then
if [[ ! -x ./shellforge ]]; then

Copilot uses AI. Check for mistakes.
echo "[run-report-agent] Building shellforge..."
go build -o shellforge ./cmd/shellforge
fi

exec ./shellforge report "${1:-.}"
Comment on lines +5 to 10
Copy link

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This build-and-run logic duplicates scripts/run-agent.sh (which already builds ./shellforge when missing). Consider delegating to run-agent.sh report ... to avoid the runners drifting (e.g., differing build flags or checks) as future changes happen.

Suggested change
if [[ ! -f ./shellforge ]]; then
echo "[run-report-agent] Building shellforge..."
go build -o shellforge ./cmd/shellforge
fi
exec ./shellforge report "${1:-.}"
exec ./scripts/run-agent.sh report "${1:-.}"

Copilot uses AI. Check for mistakes.
Loading