-
Notifications
You must be signed in to change notification settings - Fork 0
Fix issue #26: P0 bug: run-qa-agent.sh and run-report-agent.sh don't build binary if missing #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| #!/usr/bin/env bash | ||
| set -euo pipefail | ||
|
|
||
| echo "Testing fix for issue #26: run-qa-agent.sh and run-report-agent.sh build binary if missing" | ||
| echo "================================================================================" | ||
|
|
||
| # Note: We can't use rm due to governance, so we'll test differently | ||
| echo "" | ||
| echo "Note: Due to governance restrictions, we can't remove the binary." | ||
| echo "Instead, we'll verify the build logic is present in the scripts." | ||
| echo "" | ||
|
|
||
| echo "1. Checking run-qa-agent.sh has build logic..." | ||
| if grep -q "Building shellforge" scripts/run-qa-agent.sh; then | ||
| echo "✓ run-qa-agent.sh has build logic" | ||
| else | ||
| echo "✗ run-qa-agent.sh missing build logic" | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "" | ||
| echo "2. Checking run-report-agent.sh has build logic..." | ||
| if grep -q "Building shellforge" scripts/run-report-agent.sh; then | ||
| echo "✓ run-report-agent.sh has build logic" | ||
| else | ||
| echo "✗ run-report-agent.sh missing build logic" | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "" | ||
| echo "3. Comparing with run-agent.sh (reference implementation)..." | ||
| if grep -q "if \[\[ ! -f ./shellforge \]\]" scripts/run-qa-agent.sh && \ | ||
| grep -q "if \[\[ ! -f ./shellforge \]\]" scripts/run-report-agent.sh; then | ||
| echo "✓ Both scripts have the same build pattern as run-agent.sh" | ||
| else | ||
| echo "✗ Build pattern doesn't match run-agent.sh" | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "" | ||
| echo "4. Checking script syntax..." | ||
| bash -n scripts/run-qa-agent.sh && echo "✓ run-qa-agent.sh syntax OK" || exit 1 | ||
| bash -n scripts/run-report-agent.sh && echo "✓ run-report-agent.sh syntax OK" || exit 1 | ||
|
|
||
| echo "" | ||
| echo "================================================================================" | ||
| echo "All checks passed! The fix for issue #26 is implemented correctly." | ||
| echo "Both scripts now have the same build-if-missing logic as run-agent.sh." | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,4 +1,10 @@ | ||||||||||||||||
| #!/usr/bin/env bash | ||||||||||||||||
| set -euo pipefail | ||||||||||||||||
| cd "$(dirname "$0")/.." | ||||||||||||||||
|
|
||||||||||||||||
| if [[ ! -f ./shellforge ]]; then | ||||||||||||||||
| echo "[run-qa-agent] Building shellforge..." | ||||||||||||||||
| go build -o shellforge ./cmd/shellforge | ||||||||||||||||
| fi | ||||||||||||||||
|
|
||||||||||||||||
| exec ./shellforge qa "${1:-.}" | ||||||||||||||||
|
Comment on lines
+5
to
10
|
||||||||||||||||
| if [[ ! -f ./shellforge ]]; then | |
| echo "[run-qa-agent] Building shellforge..." | |
| go build -o shellforge ./cmd/shellforge | |
| fi | |
| exec ./shellforge qa "${1:-.}" | |
| exec scripts/run-agent.sh qa "${1:-.}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,4 +1,10 @@ | ||||||||||||||||
| #!/usr/bin/env bash | ||||||||||||||||
| set -euo pipefail | ||||||||||||||||
| cd "$(dirname "$0")/.." | ||||||||||||||||
|
|
||||||||||||||||
| if [[ ! -f ./shellforge ]]; then | ||||||||||||||||
| echo "[run-report-agent] Building shellforge..." | ||||||||||||||||
| go build -o shellforge ./cmd/shellforge | ||||||||||||||||
| fi | ||||||||||||||||
|
|
||||||||||||||||
| exec ./shellforge report "${1:-.}" | ||||||||||||||||
|
Comment on lines
+5
to
10
|
||||||||||||||||
| if [[ ! -f ./shellforge ]]; then | |
| echo "[run-report-agent] Building shellforge..." | |
| go build -o shellforge ./cmd/shellforge | |
| fi | |
| exec ./shellforge report "${1:-.}" | |
| exec scripts/run-agent.sh report "${1:-.}" |
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
outputs/is used by the app as a runtime artifact directory (e.g.,cmd/shellforge/main.gocreatesoutputs/logsandoutputs/reports, and.gitignoremarks these as generated). Committingoutputs/test_fix.shrisks polluting agent workflows that scanoutputs/(e.g., the report agent prompt references reading logs fromoutputs/). Consider moving this check script underscripts/ordocs/, or deleting it if it’s not intended to ship with the repo.