-
Notifications
You must be signed in to change notification settings - Fork 0
Fix issue #26: P0 bug: bug: run-qa-agent.sh and run-report-… #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,10 @@ | ||
| #!/usr/bin/env bash | ||
| set -euo pipefail | ||
| cd "$(dirname "$0")/.." | ||
|
|
||
| if [[ ! -f ./shellforge ]]; then | ||
| echo "[run-qa-agent] Building shellforge..." | ||
| go build -o shellforge ./cmd/shellforge | ||
| fi | ||
|
Comment on lines
+5
to
+8
|
||
|
|
||
| exec ./shellforge qa "${1:-.}" | ||
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,4 +1,10 @@ | ||||||||||||||||
| #!/usr/bin/env bash | ||||||||||||||||
| set -euo pipefail | ||||||||||||||||
| cd "$(dirname "$0")/.." | ||||||||||||||||
|
|
||||||||||||||||
| if [[ ! -f ./shellforge ]]; then | ||||||||||||||||
|
||||||||||||||||
| if [[ ! -f ./shellforge ]]; then | |
| if [[ ! -x ./shellforge ]]; then |
Copilot
AI
Apr 4, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script duplicates the same “build shellforge if missing” logic that already exists in scripts/run-agent.sh. To reduce duplication and keep behavior consistent, consider delegating to run-agent.sh (or extracting a shared helper) rather than re-implementing the build step here.
| if [[ ! -f ./shellforge ]]; then | |
| echo "[run-report-agent] Building shellforge..." | |
| go build -o shellforge ./cmd/shellforge | |
| fi | |
| exec ./shellforge report "${1:-.}" | |
| exec ./scripts/run-agent.sh report "${1:-.}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build guard checks
-f ./shellforge, butexec ./shellforge ...requires the binary to be executable. Ifshellforgeexists without execute permissions (e.g., from an archive/checkout), this will skip the build and then fail atexec. Consider switching the check to[[ ! -x ./shellforge ]](or verifying executability before exec).