Skip to content

Fix issue #26: P0 bug: bug: run-qa-agent.sh and run-report-… #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jpleva91 wants to merge 1 commit into from
Closed

Fix issue #26: P0 bug: bug: run-qa-agent.sh and run-report-… #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions scripts/run-qa-agent.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
#!/usr/bin/env bash
set -euo pipefail
cd "$(dirname "$0")/.."

if [[ ! -f ./shellforge ]]; then
Copy link

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build guard only checks for file existence (-f). If ./shellforge exists but is not executable (e.g., permissions lost when copying artifacts), the script will skip the build and then exec ./shellforge ... will fail. Consider checking -x (or falling back to rebuilding/chmod) so the script self-heals in this case.

Suggested change
if [[ ! -f ./shellforge ]]; then
if [[ ! -x ./shellforge ]]; then

Copilot uses AI. Check for mistakes.
echo "[run-qa-agent] Building shellforge..."
go build -o shellforge ./cmd/shellforge
fi

exec ./shellforge qa "${1:-.}"
6 changes: 6 additions & 0 deletions scripts/run-report-agent.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
#!/usr/bin/env bash
set -euo pipefail
cd "$(dirname "$0")/.."

if [[ ! -f ./shellforge ]]; then
Copy link

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build guard only checks for file existence (-f). If ./shellforge exists but is not executable (e.g., permissions lost when copying artifacts), the script will skip the build and then exec ./shellforge ... will fail. Consider checking -x (or falling back to rebuilding/chmod) so the script self-heals in this case.

Suggested change
if [[ ! -f ./shellforge ]]; then
if [[ ! -x ./shellforge ]]; then

Copilot uses AI. Check for mistakes.
echo "[run-report-agent] Building shellforge..."
go build -o shellforge ./cmd/shellforge
fi

exec ./shellforge report "${1:-.}"
Loading