This repository was archived by the owner on Aug 17, 2021. It is now read-only.
Use mod.rs for big modules and move main code into a library#10
Open
adamnemecek wants to merge 4 commits intochiptunecafe:masterfrom
Open
Use mod.rs for big modules and move main code into a library#10adamnemecek wants to merge 4 commits intochiptunecafe:masterfrom
adamnemecek wants to merge 4 commits intochiptunecafe:masterfrom
Conversation
rastertail
suggested changes
Jan 23, 2020
Comment on lines
+2
to
+22
| mod args; | ||
| mod audio; | ||
| mod commands; | ||
| mod config; | ||
| mod panic; | ||
| mod render; | ||
| mod scope; | ||
| mod state; | ||
| mod ui; | ||
|
|
||
| pub use { | ||
| args::*, | ||
| audio::*, | ||
| commands::*, | ||
| config::*, | ||
| panic::*, | ||
| render::*, | ||
| scope::*, | ||
| state::*, | ||
| ui::*, | ||
| }; No newline at end of file |
Collaborator
There was a problem hiding this comment.
Would prefer just making the modules public instead of reexporting their contents. Will require adding an extra level to all of the function calls in main.rs
| use clap::{clap_app, crate_version, AppSettings}; | ||
|
|
||
| pub fn get() -> clap::App<'static, 'static> { | ||
| pub fn args_get() -> clap::App<'static, 'static> { |
Collaborator
There was a problem hiding this comment.
I personally prefer leaving it as get(), since that along with not reexporting the modules will make the function call look like args::get() instead of args::args_get() which is cleaner to me.
rastertail
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.