Merged
Conversation
I have no idea how this worked before...
jackkoenig
added
the
Internal
jackkoenig
commented
Jan 30, 2026
| implicit val info: SourceInfo = SourceLine("Foo.scala", 1, 2) | ||
| val a = IO(Input(Bool())) | ||
| layer.block(layers.Verification.Cover) { | ||
| layer.block(chisel3.layers.Verification.Cover) { |
Contributor
Author
There was a problem hiding this comment.
This is a subtle change in Scala 3 but the compiler complains that BaseModule.layers is private [1]. Probably a change in Scala 3 for scoping rules where inherited methods win out over imported packages/objects? I'm not sure but we should probably change the name of the package private method in BaseModule, WDYT @seldridge?
jackkoenig
commented
Jan 30, 2026
Comment on lines
+36
to
38
| implicit val info: SourceInfo = SourceLine("Foo.scala", 1, 2) | ||
| val a, b, c = IO(Input(Bool())) | ||
| implicit val info = SourceLine("Foo.scala", 1, 2) | ||
| val s0: Sequence = a.delay(1) |
Contributor
Author
There was a problem hiding this comment.
To be honest, I don't know how this worked before because you get null for the SourceInfo` on the ports. But whatever the case it was erroring so I had to move the source info definitions.
seldridge
approved these changes
Jan 30, 2026
Member
seldridge
left a comment
seldridge
left a comment
There was a problem hiding this comment.
LGTM
I glanced through the interface files, but didn't really review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we only split APIs that used the SourceInfoTranform, but due to this issue discussed in #5139, we really want to do this for all public methods accepting implicit SourceInfos. It's a bit of a pain but it will make the result a lot better and AI agents are helpful here.
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash)and clean up the commit message.Create a merge commit.