Conversation
Contributor
Author
|
Marked |
jackkoenig
force-pushed
the
remove-reflective-naming
branch
from
122229f to
c3b90fd
Compare
This includes both .*Name APIs and .toTarget
This includes removal of closeUnboundIds and _onModuleClose which were hacks to support naming of non-hardware (ie. unbound) Data. This can result in a substantial performance improvement for large Modules with many public vals.
With reflective naming removed, this warning no longer does anything so the option to enable it is deprecated.
jackkoenig
force-pushed
the
remove-reflective-naming
branch
from
c3b90fd to
bab0a60
Compare
azidar
approved these changes
Jun 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is built on #2561 and will need to be rebased when that is merged. This PR reverts much of the logic added there (and deprecates some of it).
I'll note that while most reflective naming is gone, the reflective naming of
val ioinBlackBoxremains. I think that should be removed as part of the deprecation/unification ofBlackBoxandExtModule.Contributor Checklist
docs/src?Type of Improvement
API Impact
This may change some names in generated hardware, see warning in #2561.
Backend Code Generation Impact
This may change some names in generated hardware
Desired Merge Strategy
Release Notes
Remove reflective naming. In some uncommon circumstances, this may cause the names of some signals in the emitted Verilog to change. To determine if this will affect your code, please run your Chisel generator with
--warn:reflective-naming(added in Chisel v3.5.4). Note that this option only works on the older version of FIRRTL, it is a no-op in Chisel 3.6.0 and newer.Reviewer Checklist (only modified by reviewer)
3.4.x, [small] API extension:3.5.x, API modification or big change:3.6.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.