Skip to content

Add extra div cutoffs and substantial refactor#1

Open
XertroV wants to merge 7 commits intochipsTM:mainfrom
XertroV:main
Open

Add extra div cutoffs and substantial refactor#1
XertroV wants to merge 7 commits intochipsTM:mainfrom
XertroV:main

Conversation

@XertroV
Copy link
Copy Markdown

@XertroV XertroV commented May 11, 2022

I wanted some more divs to show in COTDStats, here's the draft implementation.

I also did a substantial refactor of API calls and "GameInfo" stuff.

If this is something you'd consider merging, I'm happy to polish things up and whatever to bring it in line with what you'd like.

Here's a low quality screenshot of both of them to give you an idea of the changes (note: there's a bug with the div6 time b/c it wasn't full)

image

Additional stuff:

  • I changed the API loop logic to update all divs about ~100ms after a new PB instead of the next time 15s rolls around

todos (incomplete list)

  • refactor GameInfo to not store persistent refs to some objs
  • ??

@chipsTM chipsTM marked this pull request as ready for review May 13, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant