git commit -m "fix: consolidate duplicate EmptyCard and InitialCard w…#41
Open
itsmeaabhii wants to merge 1 commit intochimon2000:masterfrom
Open
git commit -m "fix: consolidate duplicate EmptyCard and InitialCard w…#41itsmeaabhii wants to merge 1 commit intochimon2000:masterfrom
itsmeaabhii wants to merge 1 commit intochimon2000:masterfrom
Conversation
…idgets - Removed InitialCard widget (duplicate of EmptyCard) - Updated widgets barrel export to remove InitialCard - Updated home.dart to use EmptyCard for both loading and empty states - Updated tests to reflect consolidated widget usage Fixes chimon2000#37"
There was a problem hiding this comment.
Pull request overview
This PR resolves Issue #37 by removing a duplicate widget (InitialCard) and standardizing the app to use EmptyCard for both loading and empty states, reducing UI duplication and maintenance overhead.
Changes:
- Deleted
InitialCard(duplicate ofEmptyCard). - Updated the widgets barrel export to stop exporting
InitialCard. - Updated
HomePageand its widget tests to useEmptyCardfor loading/empty states.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/pages/home_test.dart | Updates widget tests to assert EmptyCard instead of the removed InitialCard. |
| lib/ui/widgets/widgets.dart | Removes initial_card.dart from the widgets barrel export. |
| lib/ui/widgets/initial_card.dart | Deletes the duplicate widget implementation. |
| lib/ui/pages/home.dart | Replaces loading-state InitialCard() usage with EmptyCard(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…idgets
Fixes #37"