Add support for skipping Applications via annotation #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applications can now be skipped during rendering by setting the com.chime.mani-diffy/render annotation to "false". This allows selective control over which Applications are processed by mani-diffy. When an Application has this annotation set to "false", it will be skipped with a log message indicating why it was skipped. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Updated the annotation to follow Kubernetes best practices: - Use forward domain format (mani-diffy.chime.com instead of com.chime.mani-diffy) - More intuitive naming: skip: "true" instead of render: "false" - Clearer intent and semantics Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Updated service.tpl to conditionally add the skip annotation - Added test-service-skipped with skipManiDiffy: true - Regenerated manifests showing the annotation in action Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
ejholmes
force-pushed
the
skip-application
branch
from
c66e74b to
71080df
Compare
Moved the ignoreSuffix check into shouldSkipRender function to centralize all skip logic in one place. This makes it easier to understand and maintain the conditions under which an Application should be skipped. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds support for skipping Applications during rendering by setting the
mani-diffy.chime.com/skipannotation to"true". This allows selective control over which Applications are processed by mani-diffy.In most cases, this can be used as a more powerful replacement to the
-ignore-suffixflag.Why
This change is needed to provide a way to exclude specific Applications from being rendered by mani-diffy. This is useful when you have Applications that should be managed differently or when you want to temporarily disable rendering for specific Applications without removing them from the repository.
How
skipAnnotationwith the value"mani-diffy.chime.com/skip"shouldSkipRender()function that checks if an Application has the annotation set to"true"walk()function to skip Applications that have this annotation set to"true"The implementation only skips Applications when the annotation is explicitly set to
"true". Applications without the annotation or with any other value will continue to be rendered normally.References
N/A