Merge @MitchBradley PR as well as all my other THREE.JS updates#14
Open
dchote wants to merge 47 commits intochilipeppr:masterfrom
Open
Merge @MitchBradley PR as well as all my other THREE.JS updates#14dchote wants to merge 47 commits intochilipeppr:masterfrom
dchote wants to merge 47 commits intochilipeppr:masterfrom
Conversation
All new shadow system (no more shader) Fixed all the deprecation warnings New font loader flow Added anti-aliasing toggle (requires reload) Saving shadow/aa state in local storage
Restructured class vars to the top of the class General readability stuff
…ly with BufferGeometry Big cleanup on the THREE.JS gcode object creation, preparing for a cleaner implementation of all of the tweening and line highlight logic Lots of duplicate state has been removed
- fixed issue with inspector and lines
Fix rendering issues caused during the merge Tweening is currently broken, actively working on a fix
…anks @MitchBradley for pointing me in the right direction on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes my rewrite for the latest THREE.JS, fixes long term bug for plane shift gcode being ignored, and also merges in @MitchBradley's awesome Mach3 IJK Absolute logic.