fix: make RNNoise bindings conditional and fix WHISPER_MODEL_PATH #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add #ifdef ENABLE_RNNOISE guards around RNNoise Python bindings - Fix WHISPER_MODEL_PATH undefined when Whisper is disabled - Allows Windows builds to succeed without RNNoise This fixes the linker error when building Python wheels on Windows where RNNoise is automatically disabled due to VLA incompatibility.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix Windows wheel build failure caused by RNNoise being disabled but Python bindings still trying to link it.
Changes
#ifdef ENABLE_RNNOISEguards around RNNoise Python bindingsWHISPER_MODEL_PATHundefined error when Whisper is disabledRoot Cause
On Windows, RNNoise is automatically disabled (due to VLA incompatibility with MSVC), but the Python bindings were unconditionally including and linking RNNoise classes, causing linker errors.
Test Plan