fix: add _USE_MATH_DEFINES for M_PI on Windows #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSVC requires _USE_MATH_DEFINES to be defined before including <cmath> to make M_PI and other math constants available. Files updated: - src/audio/audio_processor.cpp - tests/utils/test_signal_generator.h - tests/fixtures/audio_test_fixture.h - tests/unit/test_rnnoise_processor.cpp - tests/unit/test_audio_converter.cpp
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix Windows build failure caused by undefined
M_PIconstant in MSVC.Root Cause
MSVC doesn't define
M_PIby default when including<cmath>. The macro_USE_MATH_DEFINESmust be defined before including<cmath>to enable math constants.Changes
Added
_USE_MATH_DEFINESdefinition for Windows builds in:src/audio/audio_processor.cpptests/utils/test_signal_generator.htests/fixtures/audio_test_fixture.htests/unit/test_rnnoise_processor.cpptests/unit/test_audio_converter.cppTest Plan