fix: disable RNNoise on Windows due to VLA incompatibility #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSVC doesn't support C99 Variable Length Arrays (VLA), which RNNoise uses extensively. This causes compilation failures on Windows. Changes: - CMakeLists.txt: Add MSVC check to disable RNNoise on Windows with a warning message explaining the limitation - test_audio_converter.cpp: Add #ifdef ENABLE_WHISPER guard since AudioConverter is only built with Whisper enabled - test_rnnoise_processor.cpp: Add #ifdef ENABLE_RNNOISE guard since RNNoise tests require the RNNoise library
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
#ifdef ENABLE_WHISPERguard#ifdef ENABLE_RNNOISEguardRoot Cause
RNNoise uses C99 VLA in files like
pitch.c:MSVC has never supported VLA and has no plans to add support.
Test Plan