-
Notifications
You must be signed in to change notification settings - Fork 83
Add Speaker Bio field to Talk Proposal form #606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a Speaker Bio field to the Talk Proposal form, enabling speakers to provide biographical information that will be displayed publicly on meeting pages. The changes include model updates, form modifications, template enhancements, and comprehensive test coverage.
- Added a
biofield to the Presenter model to store speaker biographical information - Updated the TopicForm to include a required bio field with textarea widget
- Enhanced meeting templates to display speaker bios alongside talk descriptions
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| chipy_org/apps/meetings/models.py | Added bio TextField to Presenter model |
| chipy_org/apps/meetings/migrations/0003_add_speaker_bio.py | Database migration to add bio field |
| chipy_org/apps/talks/forms.py | Added bio field to TopicForm with validation and save logic |
| chipy_org/apps/meetings/admin.py | Added get_presenter_bios method to TopicAdmin for displaying bios |
| chipy_org/apps/meetings/templates/meetings/*.html | Updated templates to display speaker bios |
| chipy_org/apps/talks/tests/test_forms.py | Comprehensive tests for bio field functionality |
| chipy_org/apps/meetings/tests/*.py | Tests for model, admin, and template bio functionality |
| pyproject.toml | Added ipython as dev dependency |
| dev-requirements.txt | Updated requirements with ipython dependencies |
| Makefile | Enhanced with better documentation and shell-plus command |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| migrations: | ||
| docker compose exec web python manage.py makemigrations | ||
| migrations: ## create migrations name="name_of_migration" | ||
| docker compose exec web python manage.py makemigrations -n "$(name)" |
Copilot
AI
Oct 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The -n flag for makemigrations requires a value, but if no name variable is provided, this will result in an empty argument which may cause the command to fail.
| docker compose exec web python manage.py makemigrations -n "$(name)" | |
| @if [ -z "$(name)" ]; then \ | |
| echo "Error: name variable is required. Usage: make migrations name=your_migration_name"; \ | |
| exit 1; \ | |
| else \ | |
| docker compose exec web python manage.py makemigrations -n "$(name)"; \ | |
| fi |
Notes