Skip to content

IR Test Framework#2

Draft
chhagedorn wants to merge 133 commits intolworldfrom
TestingFramework
Draft

IR Test Framework#2
chhagedorn wants to merge 133 commits intolworldfrom
TestingFramework

Conversation

@chhagedorn
Copy link
Copy Markdown
Owner

@chhagedorn chhagedorn commented Apr 7, 2021 •
edited
Loading

PR to pre-review

Missing:

  • Whitelist flags DONE
  • Tests for DTest, DExclude, DScenario, DFlipC1C1, DExcludeRandom DONE
  • Update Valhalla CI flags with new framework flag names DONE
  • Turn internal tests into JTreg tests DONE
  • Add example tests on how to use the framework DONE
  • Add README.md file
  • At the end: reiterate over Javadocs and make sure everything is correct DONE
  • Improved stdout of some framework flags DONE

chhagedorn added 30 commits March 8, 2021 11:07
@chhagedorn
Initial and last commit of 2020
14b1508
@chhagedorn
Fix @run and @check, added more IR rules, refactorings, added more tests
b6e4b98
@chhagedorn
Refactor usage of TestFrameworkException
24de07c
@chhagedorn
Refactoring
85a1547
@chhagedorn
Fix helper classes and add test for it
2f5449d
@chhagedorn
Fixing how scenarios are defined, run, checked and error reported
12b6629
@chhagedorn
Add @run mode
9060277
@chhagedorn
Fix compilation level for @test
66de13b
@chhagedorn
Finishing counts rule for @ir and adding appropriate tests + fixing s…
9e66467 
…ome IR rules
@chhagedorn
Minor cleanups
11e7b54
@chhagedorn
Switch to bulk reporting for TestFormatExceptions instead of throwing…
6f4be30 
… immediately, started adding Bad tests, some refactorings
@chhagedorn
Fix @WarmUp and @DontCompile, add compile commands tests and more Bad…
ab5de84 
… tests
@chhagedorn
Add PRINT_GRAPH, Xcomp and UseCompile handling, fix public Framework …
a7fb1ac 
…checks with TriState, fix tests, fix compilation scheduling for BaseTests, add SanityTest, cleanup naming of public interface
@chhagedorn
Redesign TestFramework interface
2311388
@chhagedorn
Rename ArgumentValue <-> Argument
c99eb3b
@chhagedorn
Add MIN/MAX as possible Argument
bc5375e
@chhagedorn
Insert Copyright headers and small clean ups
31e1be9
@chhagedorn
Add more "bad" tests
a786810
@chhagedorn
Add more compiler control tests
6dfadf2
@chhagedorn
Fix @DontCompile and @ForceCompile and add tests for it, fix TestBadF…
f480f75 
…ormat reporting, added bad CompileCommand tests, added more interface methods to TestFramework and TestInfo
@chhagedorn
Update Copyright to 2021, rename INVOKE_ONCE to STANDALONE
5963c88
@chhagedorn
Finish bad tests (check, run, IR), clean up some unused code
a78e232
@chhagedorn
Fixing @DontCompile to only allow one option, start writing Javadocs
247285c
@chhagedorn
Add more bad IR tests and doing some related small fixes and clean-ups
3815a1c
@chhagedorn
Adding more IR tests
6801f53
@chhagedorn
Add IR tests for trap, scope object, completely updated the format of…
2d5f983 
… IR failure reporting and refactored the constraint matching of the IR test, add individual store/loads selection
@chhagedorn
Added remaining IR nodes for mainline with tests for them
e612085
@chhagedorn
Rename package into compiler.testframework
89dd171
@chhagedorn
Rename and move project
4760539
@chhagedorn
Move framework to /test/lib, add TestFrameworkDriver with example test
b6ddfdc
chhagedorn and others added 28 commits April 12, 2021 17:56
@chhagedorn
Fix default scenarios in Valhalla tests to also run with product version
ac22c94
@chhagedorn
Fix bug with VERIFY_IR which disabled IR verifications for scenarios,…
2d5db90 
… restore ClassFileInstaller, fix TestCallingConventionC1
@chhagedorn
Fix assertDeoptimizedByCx and improve error reporting when tests thro…
65ad9b6 
…w exceptions
@katyapav
Converted tests to new IR framework
60c06ad
@katyapav
Code style fixes
1a4720b
@chhagedorn
Cleanup Javadocs and README file, fix TestUnloadedInlineTypeField
d9de2f9
@chhagedorn
Fix timeout of TestNullableArrays and TestNullableInlineTypes
e56df00
@chhagedorn
Fix TestLWorldProfiling when run with product build
6a2aae6
@chhagedorn
Fix whitespaces + timeout of TestCallingConvention
bc6924e
@chhagedorn
Adjust whitelist
00e05a0
@chhagedorn
Apply review comments in code from Igor I. and Vladimir K.
1338286
@chhagedorn
Update and fixes from review comments
22ae413
@chhagedorn
Apply review comments and fix converted tests
52a0474
@chhagedorn
Apply review comments and refactorings
2c0967f
@chhagedorn
Add README.md file
cb45701
@chhagedorn
Move framework to test/hotspot/jtreg/compiler/lib and tests to test/h…
217a626 
…otspot/jtreg/testlibrary_tests/compiler/lib/ir_framework
@chhagedorn
Fix package names and fixing internal tests, examples and README file…
f2a8aad 
… accordingly
@chhagedorn
Update ClassFileInstaller import
4dd1469
@chhagedorn
Splitting classes into subpackages and updating README accordingly, f…
9c3bcc4 
…ix bug with new line matching in lookbehind on Windows
@chhagedorn
Merge lworld, fix conflicts and convert new IR tests to new framework
5ef29bf
@chhagedorn
Fix Compiler and CompLevel ANY and fix tests after merge
e258343
@chhagedorn
Fix tests (imports, conversion mistakes etc.)
f59b7e2
@chhagedorn
Fix converted tests
c6932b1
@chhagedorn
Fix failing internal tests on Windows and add missing flag descriptio…
3943845 
…n in README
@chhagedorn
Move tests and examples #1
8deedc6
@chhagedorn
Move tests and examples #2
e9f9c17
@chhagedorn
Update test and example package names, README files and fix some test…
1c43e46 
…s to let them pass in higher tiers
@chhagedorn
Update whitelist
5c52651
chhagedorn pushed a commit that referenced this pull request Nov 4, 2024
8340393: Open source closed choice tests #2
a9b0f9c 
Reviewed-by: psadhukhan
chhagedorn pushed a commit that referenced this pull request Feb 10, 2025
@archiecobbs
8346953: Remove unnecessary @SuppressWarnings annotations (client, #2)
9c393a2 
Reviewed-by: azvegint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TobiHartmann TobiHartmann TobiHartmann left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chhagedorn @TobiHartmann @katyapav