Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
begin interface for xtc #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
begin interface for xtc #15
Changes from all commits
d35a2f7File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check warning on line 63 in src/format.rs
src/format.rs#L63
Check warning on line 79 in src/format.rs
src/format.rs#L79
Check warning on line 131 in src/format.rs
src/format.rs#L131
Check warning on line 140 in src/format.rs
src/format.rs#L140
Check warning on line 149 in src/format.rs
src/format.rs#L149
Check warning on line 158 in src/format.rs
src/format.rs#L158
Check warning on line 167 in src/format.rs
src/format.rs#L167
Check warning on line 3 in src/formats/xtc.rs
[clippy] src/formats/xtc.rs#L3
Raw output
src/formats/xtc.rs:3:10:w:warning: unused imports: `BufRead` and `Write` --> src/formats/xtc.rs:3:10 | 3 | io::{BufRead, BufReader, BufWriter, Write}, | ^^^^^^^ ^^^^^ | = note: `#[warn(unused_imports)]` on by default __END__Check warning on line 13 in src/formats/xtc.rs
[clippy] src/formats/xtc.rs#L13
Raw output
src/formats/xtc.rs:13:29:w:warning: unused variable: `reader` --> src/formats/xtc.rs:13:29 | 13 | fn read_next(&mut self, reader: &mut BufReader<File>) -> Result<Frame, CError> { | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_reader` | = note: `#[warn(unused_variables)]` on by default __END__Check warning on line 14 in src/formats/xtc.rs
src/formats/xtc.rs#L13-L14
Check warning on line 17 in src/formats/xtc.rs
[clippy] src/formats/xtc.rs#L17
Raw output
src/formats/xtc.rs:17:24:w:warning: unused variable: `reader` --> src/formats/xtc.rs:17:24 | 17 | fn read(&mut self, reader: &mut BufReader<File>) -> Result<Option<Frame>, CError> { | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_reader` __END__Check warning on line 18 in src/formats/xtc.rs
src/formats/xtc.rs#L17-L18
Check warning on line 21 in src/formats/xtc.rs
[clippy] src/formats/xtc.rs#L21
Raw output
src/formats/xtc.rs:21:30:w:warning: unused variable: `writer` --> src/formats/xtc.rs:21:30 | 21 | fn write_next(&mut self, writer: &mut BufWriter<File>, frame: &Frame) -> Result<(), CError> { | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_writer` __END__Check warning on line 21 in src/formats/xtc.rs
[clippy] src/formats/xtc.rs#L21
Raw output
src/formats/xtc.rs:21:60:w:warning: unused variable: `frame` --> src/formats/xtc.rs:21:60 | 21 | fn write_next(&mut self, writer: &mut BufWriter<File>, frame: &Frame) -> Result<(), CError> { | ^^^^^ help: if this is intentional, prefix it with an underscore: `_frame` __END__Check warning on line 22 in src/formats/xtc.rs
src/formats/xtc.rs#L21-L22
Check warning on line 25 in src/formats/xtc.rs
[clippy] src/formats/xtc.rs#L25
Raw output
src/formats/xtc.rs:25:23:w:warning: unused variable: `reader` --> src/formats/xtc.rs:25:23 | 25 | fn forward(&self, reader: &mut BufReader<File>) -> Result<Option<u64>, CError> { | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_reader` __END__Check warning on line 26 in src/formats/xtc.rs
src/formats/xtc.rs#L25-L26
Check warning on line 29 in src/formats/xtc.rs
[clippy] src/formats/xtc.rs#L29
Raw output
src/formats/xtc.rs:29:24:w:warning: unused variable: `writer` --> src/formats/xtc.rs:29:24 | 29 | fn finalize(&self, writer: &mut BufWriter<File>) -> Result<(), CError> { | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_writer` __END__Check warning on line 30 in src/formats/xtc.rs
src/formats/xtc.rs#L29-L30