Open
Conversation
chejazi
requested changes
Nov 19, 2024
| const YourReward = remainingReward * YourShare | ||
|
|
||
| // Calculate the Annual Percentage Rate (APR) | ||
| const Apr = (YourReward / parseFloat(formatUnits(userStakedWei, decimals)) ) * 100 || 0 |
Owner
There was a problem hiding this comment.
userStakedWei and YourReward can be in different currencies. E.g. stake $REFI earn $PROXY.
I believe the current calculation assumes they are the same currency.
To fix this we'd need to fetch the USD value of the user's stake and the reward.
For normal tokens, this should be straightforward using getTokenPrices in data.ts
For LP tokens, the amount of underlying ETH and pair token needs to be read from the chain and then the prices resolved.
Author
There was a problem hiding this comment.
Sorry for the delay, I actually traveled for out of my station, I'll be back on Wednesday and I'll sort this asap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.