CHEF-15721: Add Ruby 3.4 support and prepare for habitat bundling by ashiqueps · Pull Request #560 · chef/knife-azure

ashiqueps · 2025-10-20T21:18:47Z

This PR implements Ruby 3.4 support for knife-azure and prepares it for integration with the knife habitat package, completing the first part of CHEF-15721 requirements.

Copilot

Pull Request Overview

This PR adds Ruby 3.4 support to knife-azure and addresses test failures related to license checking functionality. The changes prepare the plugin for bundling with the knife habitat package.

Key Changes

Added Ruby 3.4 CI/CD pipeline steps for both Linux and Windows platforms
Enhanced test mocking to handle license validation and file operations more robustly
Relaxed test expectations from exact counts to minimum thresholds to accommodate Ruby 3.4 behavior

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
`.expeditor/verify.pipeline.yml`	Added Ruby 3.4 build configurations for Linux (Debian Bookworm) and Windows Server 2022
`spec/spec_helper.rb`	Implemented comprehensive mocking for license checking and file operations to prevent test failures
`spec/unit/bootstrap_azurerm_spec.rb`	Updated test expectations to use `at_least` matchers and added `check_eula_license` mocking
`spec/unit/azurerm_server_create_spec.rb`	Enhanced file mocking with regex patterns and Chef extension method stubbing

spec/unit/azurerm_server_create_spec.rb

spec/spec_helper.rb

Copilot

Pull Request Overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

implement_habitat_changes.sh

habitat_integration_script.sh

habitat_integration_enhanced.sh

- Add Ruby 3.4 testing to CI pipeline (.expeditor/verify.pipeline.yml) - Update spec helper to handle licensing compatibility - Verify all 222 tests pass on Ruby 3.4.2 - Fix minor test compatibility issues for Ruby 3.4 - Prepare knife-azure for integration with knife habitat package Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>

- Add mandatory compliance reminders at the top with 🚨 warnings - Include step-by-step post-PR checklist to prevent missed requirements - Add DCO signoff verification steps - Emphasize immediate Jira field updates for AI governance - Add final compliance verification to execution protocol - Make ai-assisted label requirement more prominent - Add quick reference checklist for all critical requirements This addresses issues identified during CHEF-15721 implementation where critical compliance steps were initially missed. Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>

- Remove accidental pp statements from azurerm_server_create_spec.rb - Addresses Copilot review feedback about debug code in tests - All 147 tests continue to pass successfully Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>

- Convert single quotes to double quotes in ENV assignments - Addresses remaining Copilot style review feedback - All 36 files now pass Chefstyle inspection with no offenses Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>

Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>

Copilot

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.

lib/azure/resource_management/ARM_interface.rb

lib/chef/knife/azurerm_server_create.rb

spec/spec_helper.rb

spec/unit/azurerm_server_create_spec.rb

lib/azure/resource_management/ARM_deployment_template.rb

Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>

Copilot

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

lib/azure/resource_management/ARM_deployment_template.rb

lib/azure/resource_management/ARM_interface.rb

lib/chef/knife/azurerm_server_create.rb

Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>

Copilot

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

lib/azure/resource_management/ARM_interface.rb

lib/azure/resource_management/ARM_deployment_template.rb

knife-azure.gemspec

Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>

Copilot

Pull Request Overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

spec/spec_helper.rb:1

This mock in spec_helper.rb is overridden by the more specific mocks in azurerm_server_create_spec.rb lines 72-75. The global mock on line 72 of spec_helper will never be reached because line 71 calls and_call_original, then line 72 immediately overwrites it. Consider removing this redundant mock or clarifying the intended precedence.

$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "..", "lib"))

spec/unit/azurerm_server_create_spec.rb

spec/unit/azurerm_base_spec.rb

lib/azure/resource_management/ARM_interface.rb

Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull Request Overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull Request Overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

lib/azure/resource_management/ARM_interface.rb

spec/unit/azurerm_server_create_spec.rb

Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>

Copilot

Pull Request Overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

lib/azure/resource_management/ARM_interface.rb

lib/chef/knife/azurerm_server_create.rb

lib/azure/resource_management/ARM_deployment_template.rb

Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>

sonarqube-for-infrastructure-prod · 2025-11-11T20:46:22Z

Quality Gate failed

Failed conditions
5 New issues
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copilot

Pull Request Overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Copilot · 2025-11-11T20:46:30Z

lib/azure/resource_management/ARM_interface.rb


      def common_arm_rescue_block(error)
-        if error.class == MsRestAzure::AzureOperationError && error.body
+        if (error.is_a?(MsRestAzure2::AzureOperationError) || error.is_a?(MsRestAzure2::AzureOperationError)) && error.body


The conditional check is redundant - both sides of the OR operator check for the same class MsRestAzure2::AzureOperationError. The second check should likely verify a different exception type (possibly the original MsRestAzure::AzureOperationError for backward compatibility) or this should be simplified to a single check.

Suggested change

if (error.is_a?(MsRestAzure2::AzureOperationError) || error.is_a?(MsRestAzure2::AzureOperationError)) && error.body

if (error.is_a?(MsRestAzure2::AzureOperationError) || error.is_a?(MsRestAzure::AzureOperationError)) && error.body

Copilot · 2025-11-11T20:46:30Z

.github/copilot-instructions.md

+✅ Jira Field: [Verify customfield_11170 = 'Yes']
+
+📋 All compliance requirements satisfied? [Yes/No]
+If No, identify and fix missing items before completing."


[nitpick] Corrected capitalization: 'If No' should be 'If no' for consistency with standard sentence formatting.

Suggested change

If No, identify and fix missing items before completing."

If no, identify and fix missing items before completing."

Copilot AI review requested due to automatic review settings October 20, 2025 21:18

ashiqueps added Type: Enhancement Adds new functionality. Platform: Azure ai-assisted Work completed with AI assistance following Progress AI policies labels Oct 20, 2025

Copilot AI reviewed Oct 20, 2025

View reviewed changes

spec/unit/azurerm_server_create_spec.rb Show resolved Hide resolved

spec/unit/azurerm_server_create_spec.rb Show resolved Hide resolved

spec/spec_helper.rb Show resolved Hide resolved

Copilot AI review requested due to automatic review settings October 20, 2025 21:45

Copilot AI reviewed Oct 20, 2025

View reviewed changes

implement_habitat_changes.sh Outdated Show resolved Hide resolved

habitat_integration_script.sh Outdated Show resolved Hide resolved

habitat_integration_enhanced.sh Outdated Show resolved Hide resolved

ashiqueps added 6 commits October 27, 2025 14:39

Fix Chefstyle string literal violations

7db9798

- Convert single quotes to double quotes in ENV assignments - Addresses remaining Copilot style review feedback - All 36 files now pass Chefstyle inspection with no offenses Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>

Removed the unwanted files

9c27961

Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>

Using the forked gems

96281f5

Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>

Copilot AI review requested due to automatic review settings October 27, 2025 09:09

ashiqueps force-pushed the CHEF-15721 branch from bcdd9c0 to 96281f5 Compare October 27, 2025 09:09

Copilot AI reviewed Oct 27, 2025

View reviewed changes

ashiqueps added 2 commits October 27, 2025 14:43

Updated the windows image

a08b629

Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>

Style issue fixes

44654f4

Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>

Copilot AI review requested due to automatic review settings October 27, 2025 09:23

Copilot AI reviewed Oct 27, 2025

View reviewed changes

lib/azure/resource_management/ARM_deployment_template.rb Outdated Show resolved Hide resolved

lib/azure/resource_management/ARM_interface.rb Outdated Show resolved Hide resolved

lib/chef/knife/azurerm_server_create.rb Outdated Show resolved Hide resolved

ashiqueps added 2 commits October 27, 2025 15:03

Fixed the specs

8d3fbf2

Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>

Fixed the style issues

c74af9f

Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>

Copilot AI review requested due to automatic review settings October 27, 2025 09:34

Copilot AI reviewed Oct 27, 2025

View reviewed changes

ashiqueps added 2 commits October 27, 2025 15:20

Fixed the specs with openssl failures

b08fbb2

Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>

Fixed the specs for ruby 3.1

beef117

Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>

Copilot AI review requested due to automatic review settings October 27, 2025 10:36

Copilot AI reviewed Oct 27, 2025

View reviewed changes

spec/unit/azurerm_server_create_spec.rb Show resolved Hide resolved

spec/unit/azurerm_base_spec.rb Outdated Show resolved Hide resolved

lib/azure/resource_management/ARM_interface.rb Outdated Show resolved Hide resolved

ashiqueps and others added 2 commits October 27, 2025 16:10

Fixed the style issues

03b1f84

Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>

Apply suggestion from @Copilot

512e841

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings October 27, 2025 12:25

Copilot AI reviewed Oct 27, 2025

View reviewed changes

Apply suggestion from @Copilot

969d70c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings October 27, 2025 12:27

Apply suggestion from @Copilot

7f42391

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI reviewed Oct 27, 2025

View reviewed changes

lib/azure/resource_management/ARM_interface.rb Outdated Show resolved Hide resolved

spec/unit/azurerm_server_create_spec.rb Show resolved Hide resolved

ashiqueps added 4 commits October 27, 2025 18:07

Review comments

29968e5

Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>

Merge branch 'CHEF-15721' of github.com:chef/knife-azure into CHEF-15721

d77497d

Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>

Updated the linux version and spec fixes

ee91e42

Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>

Fixed the additional specs

57fc1f7

Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>

Copilot AI review requested due to automatic review settings October 27, 2025 13:01

Copilot AI reviewed Oct 27, 2025

View reviewed changes

lib/azure/resource_management/ARM_interface.rb Outdated Show resolved Hide resolved

lib/chef/knife/azurerm_server_create.rb Show resolved Hide resolved

lib/azure/resource_management/ARM_deployment_template.rb Show resolved Hide resolved

Moved the windows tests to its own file

b8aac24

Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>

nikhil2611 approved these changes Oct 29, 2025

View reviewed changes

sanjain-progress approved these changes Oct 29, 2025

View reviewed changes

Fixed the issue with faraday-cookie_jar gem

f9d7173

Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>

Copilot AI review requested due to automatic review settings November 11, 2025 20:45

Copilot AI reviewed Nov 11, 2025

View reviewed changes

	if (error.is_a?(MsRestAzure2::AzureOperationError) \|\| error.is_a?(MsRestAzure2::AzureOperationError)) && error.body
	if (error.is_a?(MsRestAzure2::AzureOperationError) \|\| error.is_a?(MsRestAzure::AzureOperationError)) && error.body

	If No, identify and fix missing items before completing."
	If no, identify and fix missing items before completing."

Conversation

ashiqueps commented Oct 20, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqube-for-infrastructure-prod bot commented Nov 11, 2025

Quality Gate failed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!