Remove Buildkite unit/lint tests from expeditor config #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaymzh
force-pushed
the
nuke-dupe-tests
branch
from
0b6f2a7 to
0465d44
Compare
Collaborator
Author
|
I can't figure out how to make expeditor stop trying to run verify - I already removed it from the config. :/ |
**NOTE**: Don't merge this without: - removing 'verify' from the 'required checks' in the GH conifg - ADDING 'all checks' to the 'required checks' in the GH config Now that unit/lint tests are matched on GH to BK, we can remove the ones on BK, which are slower and cause more issues. This ALSO adds the 'all checks' check so we can easily just tell GH to block merges on that passing. Signed-off-by: Phil Dibowitz <phil@ipom.com>
tpowell-progress
force-pushed
the
nuke-dupe-tests
branch
from
0465d44 to
30e3b2b
Compare
Contributor
|
|
johnmccrae
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Don't merge this without:
Now that unit/lint tests are matched on GH to BK, we can remove
the ones on BK, which are slower and cause more issues.
This ALSO adds the 'all checks' check so we can easily just tell
GH to block merges on that passing.
Signed-off-by: Phil Dibowitz phil@ipom.com