Skip to content

Allow usage of google-protobuf 4.x+ #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
julik merged 9 commits into from
Jun 18, 2025
Merged

Allow usage of google-protobuf 4.x+ #63

julik merged 9 commits into from
Jun 18, 2025

Conversation

@julik
Copy link
Contributor

@julik julik commented Jun 18, 2025 •
edited
Loading

  • Test with Rails 7.2 and Rails 8.0 only
  • Force Rails version in Appraisals which does not have the response body issue
  • Generate the test protobuf message descriptors instead of writing them out by hand. Newer protoc has a very different output compared to what it used to be, and there is no longer a .build available in the protobuf gem 4.x

julik added 5 commits June 18, 2025 18:38
@julik
Regenerate Appraisals, drop Rails 7.0
a660b1a
@julik
Allow usage of google-protobuf 4.x
f0d607a 
so that binary gems can be easily installed for use with pbbuilder
@julik
Use an actual .proto for testing
4470c97 
The format of the descriptor output changes between google-protobuf 3.x and 4.x and defining it "neatly" inline is no longer possible, but that's not a big deal.
@julik
Test with both google-protobuf 3.25 and 4.x
b13ad2e
@julik
Remove --verbose when running rake test
7db38cd 
because the only thing it prints are test names and timings - and not in a very compact form
@julik julik requested a review from svanhesteren June 18, 2025 17:09
@julik julik merged commit 689b258 into main Jun 18, 2025
2 checks passed
@julik julik deleted the update-protobuf-dep branch June 18, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svanhesteren svanhesteren svanhesteren approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@julik @svanhesteren