Conversation
trisdoan
reviewed
Jul 1, 2024
chaule97
force-pushed
the
16.0-fix-purchase_date_planned_manual
branch
3 times, most recently
from
4e14b6b to
2c42b63
Compare
chaule97
changed the title
chaule97
changed the title
chaule97
force-pushed
the
16.0-fix-purchase_date_planned_manual
branch
from
2c42b63 to
105b088
Compare
trisdoan
reviewed
Jul 5, 2024
purchase_date_planned_manual_product_packaging_container_deposit/__manifest__.py
Outdated
Show resolved
Hide resolved
trisdoan
suggested changes
Jul 5, 2024
purchase_date_planned_manual_product_packaging_container_deposit/__manifest__.py
Outdated
Show resolved
Hide resolved
purchase_date_planned_manual_product_packaging_container_deposit/models/purchase_order.py
Outdated
Show resolved
Hide resolved
...nual_product_packaging_container_deposit/tests/test_date_planned_manual_container_deposit.py
Outdated
Show resolved
Hide resolved
purchase_date_planned_manual_product_packaging_container_deposit/readme/USAGE.rst
Outdated
Show resolved
Hide resolved
chaule97
force-pushed
the
16.0-fix-purchase_date_planned_manual
branch
from
105b088 to
7081dfc
Compare
chaule97
changed the title
chaule97
force-pushed
the
16.0-fix-purchase_date_planned_manual
branch
3 times, most recently
from
92b3881 to
2de8bed
Compare
trisdoan
reviewed
Jul 8, 2024
purchase_date_planned_manual_container_deposit_product/models/container_deposit_order_mixin.py
Outdated
Show resolved
Hide resolved
trisdoan
approved these changes
Jul 8, 2024
trisdoan
left a comment
trisdoan
left a comment
There was a problem hiding this comment.
pre-approving
Note
- I could not reproduce the issue. When adding product, whose packaging has a container deposit, it does not change the PO's date_planned (which is correct). However, I encountered it with allo.
- There must be something in between them, I dont know atm.
- Budt I do believe it's an issue when date_planned of container depposit is different from the main product.
=> So, I suggest you mention it in the PR's description that this glue module makes those lines have a same date_planned
chaule97
force-pushed
the
16.0-fix-purchase_date_planned_manual
branch
3 times, most recently
from
f77c2ad to
b5e589a
Compare
…te_planned is set manually, prevent calculation of the field upon PO confirmation
chaule97
force-pushed
the
16.0-fix-purchase_date_planned_manual
branch
from
b5e589a to
75173d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
purchase_date_planned_manual_container_deposit_product: When date_planned is set manually and add product attached to container deposit, prevent calculation when clicking PO Confirm