Skip to content

Implement GainData as dataclass #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chaudum wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement GainData as dataclass #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 6 additions & 31 deletions rgain3/lib/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.

import enum
from dataclasses import dataclass

from .version import __version__

Expand All @@ -27,8 +28,8 @@ class GainType(enum.Enum):
TP_ALBUM = "TP_ALBUM"


@dataclass
class GainData:

"""A class that contains Replay Gain data.

Arguments for ``__init__`` are also instance variables. These are:
Expand All @@ -37,36 +38,10 @@ class GainData:
- ``ref_level``: the used reference level (in dB)
"""

def __init__(self,
gain,
peak=1.0,
ref_level=89,
gain_type=GainType.TP_UNDEFINED):
self.gain = gain
self.peak = peak
self.ref_level = ref_level
self.gain_type = gain_type

def __str__(self):
return "gain={.2f} dB; peak={.8f}; reference-level={} dB".format(
Copy link
Owner Author

@chaudum chaudum Mar 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The syntax error was caused by the float fomatting, which misses the colon and should be {:2f}.

self.gain, self.peak, self.ref_level
)

def __repr__(self):
return "{}({}, {}, {}, {})".format(
self.__class__.__name__,
self.gain, self.peak, self.ref_level, self.gain_type
)

def __eq__(self, other):
return isinstance(other, GainData) and (
self.gain == other.gain and
self.peak == other.peak and
self.ref_level == other.ref_level and
self.gain_type == other.gain_type)

def __ne__(self, other):
return not self.__eq__(other)
gain: float
peak: float = 1.0
ref_level: int = 89
gain_type: GainType = GainType.TP_UNDEFINED


class GSTError(Exception):
Expand Down