Skip to content

improvement: mark _send as abstract, add docs #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WofWca wants to merge 1 commit into
base: main
Choose a base branch
from
Open

improvement: mark _send as abstract, add docs #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions typescript/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,14 @@ export abstract class BaseTransport<T = {}>
{
private _requests: RequestMap = new Map();
private _requestId = 0;
_send(_message: Message): void {
throw new Error("_send method not implemented");
}
abstract _send(_message: Message): void

close() {}

/**
* This must be invoked by the implementor of {@link BaseTransport},
* on incoming messages.
*/
protected _onmessage(message: Message): void {
if ((message as Request).method) {
const request = message as Request;
Expand Down