Upgrade dependencies, misc. fixes #22 #27
+91
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Meanwhile, I added more updates to my fork today, https://github.com/FranklinChen/cxsd/tree/upgrade-dependencies |
myabc
force-pushed
the
feature/upgrade-dependencies
branch
from
a758f1d to
2a36a5f
Compare
Although Bluebird appears to support ES5 at runtime, its typings now depend on ES6 Map: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/00cb71a36a31ec77e0f8c4c4598cc7d457385bf1/types/bluebird/index.d.ts#L660
myabc
force-pushed
the
feature/upgrade-dependencies
branch
from
2a36a5f to
537fbdd
Compare
Author
|
@FranklinChen I haven't looked at this code in a long-time so it may make sense for you to raise an alternate PR - or I can give give you write access to my repo. |
|
@myabc I haven't fully tested out my branch yet, I merely got it building today. Monday I'll try to actually use my branch to get something working, and once I've verified that, I'll revisit. |
|
Interested in using this library so if the fixes can get through, much better 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces PR #22