Skip to content

Conversation

@dsloanm
Copy link
Contributor

@dsloanm dsloanm commented Dec 11, 2025

Pre-submission checklist

  • I read and followed the CONTRIBUTING guidelines.
  • I have ensured that the documentation tests complete successfully.

Summary of Changes

Un-orphans the existing draft Glossary and populates it with definitions and resource links. The focus is on providing definitions for Charmed HPC charms in order to address #90. This includes the Slurm charms, Apptainer, filesystem-client, InfluxDB, and SSSD. Charms not maintained by the Charmed HPC team are not directly defined but references are provided, e.g. the COS charms are not defined but COS itself is and the documentation linked to.

The documentation tests currently fail due to the known issue of spellcheck applying to code/command blocks.

Related Issues, PRs, and Discussions

Closes #90

@dsloanm dsloanm requested a review from a team as a code owner December 11, 2025 16:37
@dsloanm dsloanm requested review from NucciTheBoss and removed request for a team December 11, 2025 16:37
@dsloanm dsloanm added the docs This pull request makes a change to the documentation label Dec 11, 2025
@dsloanm dsloanm requested a review from AshleyCliff December 11, 2025 16:54
Copy link
Contributor

@AshleyCliff AshleyCliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work! I've made some suggestions around formatting and added a few resource links.

Comment on lines 12 to 19
Apptainer
HPC-focused container runtime. Formerly Singularity.
Refers to both the software and the corresponding charm.
Resources:
- [Apptainer - Portable, Reproducible Containers](https://apptainer.org/)
- [Charmhub | apptainer](https://charmhub.io/apptainer)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Apptainer
HPC-focused container runtime. Formerly Singularity.
Refers to both the software and the corresponding charm.
Resources:
- [Apptainer - Portable, Reproducible Containers](https://apptainer.org/)
- [Charmhub | apptainer](https://charmhub.io/apptainer)
Apptainer
HPC-focused container runtime. Formerly Singularity.
Resources:
- [Apptainer - Portable, Reproducible Containers](https://apptainer.org/)
- [apptainer charm](https://charmhub.io/apptainer)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than repeat the 'software and corresponding charm' statement in a variety of places, I think simply pointing to both the source and the charm in the resources makes that point with less words.

I'd suggest something more like this for each of the places with that statement.

Amazon Web Services (AWS)
A cloud platform provided by Amazon that can be used to host Charmed HPC. See the [AWS website](https://aws.amazon.com/) for more information.
A cloud platform provided by Amazon that can be used to host Charmed HPC.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I both like and don't like that this refers to its use in relation to Charmed HPC. For a glossary specifically, we might want to keep it to the general details and let our other docs show how it relates to Charmed HPC. @NucciTheBoss thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the glossary, let's keep the definitions general and not specific to Charmed HPC unless it's necessary like "what's slurm-ops". We should treat our glossary like Wikipedia where the linked resources are not tightly related to the original topic.

This way we don't have to worry about Charmed HPC "detracting" from the goal of adding topics like AWS and Slurm to the glossary which is to help people better understand the external technologies we are working with. Our docs will then demonstrate the relationship these technologies have with Charmed HPC. E.g. "What's this AWS Charmed HPC is being deployed on. Ah! Amazon Web Services"

Comment on lines 27 to 29
Ceph
Distributed storage system that provides object, block, and file storage.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Ceph
Distributed storage system that provides object, block, and file storage.
Ceph
Distributed storage system that provides object, block, and file storage.
Resources: [ceph](https://ceph.io/en/), [Charmed ceph](https://ubuntu.com/ceph/docs)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check that those are the most appropriate places to link to. Thoughts on having the links on a single line? It would condense the term blocks a bit which might help with distinguishing one term block from the next. (If we like this, we should do it for all of them)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AshleyCliff we should link to the microceph docs instead as we're using microceph and not the legacy Charmed Ceph.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure which one we were using tbh - and if I'm not sure, we should anticipate users being in a similar boat and spell out the microceph to ceph relationship

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the links on a single line with how it improves the layout but it can be tricky to see where one link ends and the next begins with a comma between them. I think putting a • between them makes it a bit clearer. I'll make the change and see what people think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having said that. this still seems a bit clustered:

dot

I'll change it to the following instead since the 🌐 makes it crystal clear where links begin:

emoji

Comment on lines +30 to +31
CephFS
POSIX-compliant file system interface that runs on top of a Ceph storage cluster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CephFS
POSIX-compliant file system interface that runs on top of a Ceph storage cluster.
CephFS
POSIX-compliant file system interface that runs on top of a Ceph storage cluster.
Resources: [Ceph file system](https://docs.ceph.com/en/latest/cephfs/)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also include a link here to the microceph docs for CephFS and maybe the CephFS charm. Thoughts @dsloanm?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll give MicroCeph its own glossary entry since it's a separate entity to Ceph and CephFS. It's just the (very strongly) recommended path to achieving Ceph.

@dsloanm
Copy link
Contributor Author

dsloanm commented Dec 12, 2025

The latest commits should address comments. Let me know your thoughts on use of 🌐 for the resource links. I think it delimits the links clearly but the emoji may be too distracting

@dsloanm dsloanm requested a review from AshleyCliff December 12, 2025 15:45
Copy link
Contributor

@AshleyCliff AshleyCliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for all the work!

@AshleyCliff AshleyCliff merged commit 4d1b388 into charmed-hpc:main Dec 12, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs This pull request makes a change to the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Descriptive explanations for each Charmed HPC charm

3 participants