feat: enable timestamps by default in New()#192
Open
jamesainslie wants to merge 4 commits intocharmbracelet:mainfrom
Open
feat: enable timestamps by default in New()#192jamesainslie wants to merge 4 commits intocharmbracelet:mainfrom
jamesainslie wants to merge 4 commits intocharmbracelet:mainfrom
Conversation
Replace New() calls with NewWithOptions() using empty Options struct. Prepares codebase for upcoming change to New() default behavior.
BREAKING CHANGE: New() now sets ReportTimestamp: true.
Previous behavior available via NewWithOptions(w, Options{}).
Add HandlerOptions struct and NewTextHandler/NewJSONHandler functions. Provides familiar API for users migrating from log/slog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Users expect
log.New()to behave likelog.Default(), but timestamps are omitted. This inconsistency causes confusion since most logging use cases require timestamps for debugging and observability.See discussion: #191
Summary
Enable timestamps by default in
New()and add slog-compatible handler constructors.Changes
New()now setsReportTimestamp: trueby defaultHandlerOptionsstruct for slog-style configurationNewTextHandler()andNewJSONHandler()constructorsNewWithOptions()explicitlyBreaking Change
New()now includes timestamps. Previous behavior available via:New API
Closes #191