provide app with the lib for testing and reading#424
Open
john-peterson wants to merge 1 commit intocharmbracelet:masterfrom
Open
provide app with the lib for testing and reading#424john-peterson wants to merge 1 commit intocharmbracelet:masterfrom
john-peterson wants to merge 1 commit intocharmbracelet:masterfrom
Conversation
instantly test your changes ! go run glamour/main.go examples/artichokes/*md or use as stand alone file reader go install github.com/charmbracelet/glamour/glamour@master glamour test.md
Member
andreynering
left a comment
andreynering
left a comment
There was a problem hiding this comment.
Hey @john-peterson, thanks for opening this PR.
We already have a standalone product to render markdown files, Glow. It's even possible to change Glamour changes with it, you just need a replace directive on your go.mod (although I know it's less convenient).
What about moving this file into examples/filesystem/main.go? It'd allow you to test Glamour code changes as well, but that means we won't promise stability on this binary.
Also, can you fix all lint issues?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instantly test your changes !
go run glamour/main.go examples/artichokes/*md
or use as stand alone file reader
go install github.com/charmbracelet/glamour/glamour@master
glamour test.md