fix tool calls with empty streamed arguments#156
Open
mavaa wants to merge 1 commit intocharmbracelet:mainfrom
Open
fix tool calls with empty streamed arguments#156mavaa wants to merge 1 commit intocharmbracelet:mainfrom
mavaa wants to merge 1 commit intocharmbracelet:mainfrom
Conversation
Author
|
Update, as discussed, I wanted to test using anthropic directly, and while I'm not 100% certain (this issue doesn't always trigger), it seems like this only happens when using Claude models through Github Copilot Pro. This test with Anthropic api directly worked fine, but I don't have many api tokens left there, and don't want to buy more: 
Here's the exact same prompt through Copilot (and some bickering...): 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.md.I'm having a very specific issue with using Claude (through GitHub Pro) in crush and it calling the List command without any parameters (Tested with Opus 4.6 and Haiku 4.5). It will just hang forever, and this happens a lot for me, cause Claude seems to be doing this any time it wants to look in the current dir:
Also tested with GPT-5.2 (also Copilot Pro), and it doesn't seem to have the same issue:
I vibed/discussed it in crush itself, and we found out the issue seems to be that Claude models somehow sends a "" as argument while it should be "{}", and it causes a crash in the fantasy lib. Now, we managed to fix this with the change in this PR, where the parameter is corrected if it's just an empty string. This works perfectly for me now, but it feels kinda like a hack, so after some discussion in Discord, I'm posting it here (a bit late).
I have verified that I'm still having this issue on the latest version of crush as well, 0.46.2 as of this writing.