fix: enable reasoning for o1 model#85
Open
Peteskiis wants to merge 1 commit intocharmbracelet:mainfrom
Open
Conversation
caarlos0
approved these changes
Oct 16, 2025
caarlos0
requested changes
Oct 16, 2025
Member
caarlos0
left a comment
There was a problem hiding this comment.
the openrouter.json file is auto generated - are you sure you didn't mean to change openai.json?
in any case, seems like openrouter reports o1 without reasoning 🤔
d3edbce to
aac7f12
Compare
Author
|
yeah, the issue was from openrouter. I updated openai.json. |
Contributor
|
@Peteskiis thanks for the PR, have you made sure that the changes work as expected in crush? You can test it locally by running the catwalk server This will help me validate the configuration too :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.md.