Add temperature=0.9 and top_p=0.95 to zai-glm-4.7 model#163
Open
sebastiand-cerebras wants to merge 1 commit intocharmbracelet:mainfrom
Open
Add temperature=0.9 and top_p=0.95 to zai-glm-4.7 model#163sebastiand-cerebras wants to merge 1 commit intocharmbracelet:mainfrom
sebastiand-cerebras wants to merge 1 commit intocharmbracelet:mainfrom
Conversation
Member
andreynering
left a comment
There was a problem hiding this comment.
It's not possible to set this currently, so I think I'll just close this PR.
Let me know if I'm missing anything.
Comment on lines
+68
to
+69
| "temperature": 1, | ||
| "top_p": 0.95 |
Member
There was a problem hiding this comment.
You can actually only set the fields available in this struct for now:
catwalk/pkg/catwalk/provider.go
Lines 68 to 82 in bf6200e
Contributor
|
@andreynering these can go under // ModelOptions stores extra options for models.
type ModelOptions struct {
Temperature *float64 `json:"temperature,omitempty"`
TopP *float64 `json:"top_p,omitempty"`
TopK *int64 `json:"top_k,omitempty"`
FrequencyPenalty *float64 `json:"frequency_penalty,omitempty"`
PresencePenalty *float64 `json:"presence_penalty,omitempty"`
ProviderOptions map[string]any `json:"provider_options,omitempty"`
} |
Contributor
|
@sebastiand-cerebras can you move them to the correct place? |
Member
|
should these options even be here? I think these should be on the clients instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added "temperature": 0.9, "top_p": 0.95 to zai-glm-4.7 model (also removed duplicate entry)
Will this work?:) Thanks for letting me know. If not, then probs do not merge it.