Node 22 compatibility #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansonipaypal
approved these changes
May 12, 2025
Collaborator
ansonipaypal
left a comment
ansonipaypal
left a comment
There was a problem hiding this comment.
One minor question, rest LGTM.
lony25
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Node 22 onwards, there is failure while calling PUT request:
The issue arises because of changes in the behavior of the module in Node.js 22 compared to Node.js 16. Specifically, the secureConnect event may not be emitted as expected in Node.js 22 due to stricter handling of TLS connections or changes in the event lifecycle.
In this change, We are using the
connectevent Instead ofsecureConnecton socket connection while callinghttps.request.