Charge Control C / Development: minor fixes #56
Conversation
barsnick
commented
Jun 27, 2025
barsnick
commented
- fix example output
- fix copy command
- add note about parallel jobs
docs/source/development.rst
Outdated
|
|
||
| .. code-block:: console | ||
| make install -j4 |
There was a problem hiding this comment.
I understand the problem, but in my VM case ( nproc = 2 ) this suggestion would make things worse. Sure you mention to lower the number, but a newbie isn't aware how to figure the right one.
So what about dropping the j parameter for the low memory case?
Or at least explain what is little RAM?
Or mention that VM is usually very constraint regarding resources?
There was a problem hiding this comment.
You are right, a fixed number may make things worse.
In fact, while this often happens in our VMs, this change addresses a case noticed both by us and by a customer in WSL2: The PC has 12 cores, and assigns all 12 to WSL2, but only reserves limited RAM. This is bound to fail. (The customer just repeated the build until it succeeded.)
Let's find a different way to address this.
lategoodbye
left a comment
lategoodbye
left a comment
There was a problem hiding this comment.
Looks good except of the comment
barsnick
force-pushed
the
everest/ccc-development-minor-fixes
branch
from
2cfc695 to
58a009d
Compare
|
I dropped the commit about parallel compilation. We need to revise this section later, in a separate PR. |
Also add `-v` verbose flag to `cp` to visualize what actually happens. Signed-off-by: Moritz Barsnick <moritz.barsnick@chargebyte.com>
Signed-off-by: Moritz Barsnick <moritz.barsnick@chargebyte.com>
barsnick
force-pushed
the
everest/ccc-development-minor-fixes
branch
from
58a009d to
908cd9d
Compare
