Everest/ccc: Revision of development chapter #53
Conversation
Signed-off-by: Fabian Hartung <fabian.hartung@chargebyte.com>
Signed-off-by: Fabian Hartung <fabian.hartung@chargebyte.com>
|
I would adjust chargesom as soon as we are through with the review here |
barsnick
left a comment
barsnick
left a comment
There was a problem hiding this comment.
Much nicer than before.
Some small issues noted.
docs/source/development.rst
Outdated
| .. literalinclude:: ../../includes/_static/files/toolchain.cmake | ||
|
|
||
| #. Create a new :code:`build` directory in "my-module" and navigate to it. | ||
| #. Create a new :code:`build_tarragon` directory in the EVerest project directory (e.g. inside :code:`everest-core`): |
There was a problem hiding this comment.
I believe this should still reference the module directory, in case the user is developing in their own dir.
There was a problem hiding this comment.
I would like to show both opportunities (cross-compile own module directory and everest-core).. I try to improve it.
| .. code-block:: console | ||
| cmake -DCMAKE_TOOLCHAIN_FILE=../toolchain/toolchain.cmake -DCMAKE_SYSROOT=/mnt/rootfs .. | ||
| cmake -DCMAKE_TOOLCHAIN_FILE=../../toolchain/toolchain.cmake -DCMAKE_SYSROOT=/mnt/rootfs .. |
There was a problem hiding this comment.
At this point, I hope that the user sticks to the common EVerest directory structure (with modules/MyModule/, interfaces/, types/). Is that noted somewhere in the prerequisites for development?
Rework after review Signed-off-by: Fabian Hartung <fabian.hartung@chargebyte.com>
barsnick
left a comment
barsnick
left a comment
There was a problem hiding this comment.
I found one more issue.
Signed-off-by: Stefan Wahren <stefan.wahren@chargebyte.com>
Revision of the cross-compile chapter